runtime: Classify top level sce command failures with typed user-error catalog - #223
Open
stefanskoricdev wants to merge 8 commits into
Open
runtime: Classify top level sce command failures with typed user-error catalog#223stefanskoricdev wants to merge 8 commits into
stefanskoricdev wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
stefanskoricdev
force-pushed
the
feat/improve-cli-errors
branch
from
August 20, 2026 13:05
1c1f349 to
97714cb
Compare
stefanskoricdev
changed the title
stefanskoricdev
marked this pull request as ready for review
August 21, 2026 08:58
Expose credential-storage and unexpected sync failures through the closed user-error catalog, preserving technical sources for observability while emitting redacted, unstyled terminal messages. Add typed storage predicates across sync error layers. Co-authored-by: SCE <sce@crocoder.dev>
Classify authentication, storage, and fallback failures through the shared CliError user-error catalog while preserving technical sources for observability. Co-authored-by: SCE <sce@crocoder.dev>
Expose missing Git repository failures through the stable user-error catalog while preserving technical sources for observability. Co-authored-by: SCE <sce@crocoder.dev>
davidabram
force-pushed
the
feat/improve-cli-errors
branch
from
August 24, 2026 15:23
8d52c20 to
b57c6a8
Compare
Classify credential-storage failures from stream batches and refreshes as `auth.storage_unavailable` instead of generic unexpected failures while preserving the typed technical source for observability. Add focused terminal and refresh coverage and update the sync error documentation. Plan: fix-pr-223-error-classification-regressions (T01) Co-authored-by: SCE <sce@crocoder.dev>
Distinguish Git-confirmed non-repository directories from unexpected resolution failures so setup reports the correct stable user error without misclassifying missing or inaccessible paths. Preserve the technical source through the typed setup error and add focused classification and source-preservation tests. Plan: fix-pr-223-error-classification-regressions (T02) Co-authored-by: SCE <sce@crocoder.dev>
Distinguish a missing Git repository from other Git command failures using the command's leading diagnostic instead of matching any later occurrence of the phrase. Normalize Git's locale and preserve typed command errors so unexpected failures retain their original cause and diagnostics. Co-authored-by: SCE <sce@crocoder.dev>
Treat missing credentials as successful logout and whoami state queries while preserving typed failures for authenticated and storage errors. Add text/JSON regression coverage and update the documented command and error contracts. Plan: fix-pr-223-error-classification-regressions (T03) Co-authored-by: SCE <sce@crocoder.dev>
Prevent `auth logout` and unauthenticated `whoami` text output from acquiring ANSI styling in non-color contexts by passing the renderer's color decision explicitly. Preserve JSON payloads and existing logout semantics, and record the completed regression criteria and validation evidence. Plan: fix-pr-223-error-classification-regressions (AC1–AC7) Co-authored-by: SCE <sce@crocoder.dev>
davidabram
force-pushed
the
feat/improve-cli-errors
branch
from
August 26, 2026 13:46
c68caeb to
10a930e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commands.
repositories, and unexpected failures.
messages.